-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm openssl pulled in linux #1739
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
- Coverage 29.22% 29.17% -0.05%
==========================================
Files 49 49
Lines 17488 17554 +66
Branches 8457 8482 +25
==========================================
+ Hits 5110 5122 +12
- Misses 7252 7258 +6
- Partials 5126 5174 +48
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
93a8b64
to
6f97da5
Compare
I've rebased against main, so this PR is now ready to merge. |
Seems that it broke one of the Ubuntu test |
6f97da5
to
199de56
Compare
Honestly, I have no idea why changing tls implementation would break |
I think a unit test might be in order to verify this more atomically |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
199de56
to
68aea4e
Compare
Superseded by #1742 |
Follow up for #1737
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com