Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm openssl pulled in linux #1739

Closed
wants to merge 1 commit into from

Conversation

NobodyXu
Copy link
Contributor

Follow up for #1737

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch coverage: 46.15% and project coverage change: -0.05 ⚠️

Comparison is base (3b70d6b) 29.22% compared to head (68aea4e) 29.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
- Coverage   29.22%   29.17%   -0.05%     
==========================================
  Files          49       49              
  Lines       17488    17554      +66     
  Branches     8457     8482      +25     
==========================================
+ Hits         5110     5122      +12     
- Misses       7252     7258       +6     
- Partials     5126     5174      +48     
Impacted Files Coverage Δ
src/cache/azure.rs 0.00% <0.00%> (ø)
src/cache/cache.rs 38.37% <0.00%> (+0.28%) ⬆️
src/cache/gcs.rs 9.80% <0.00%> (ø)
src/cache/gha.rs 0.00% <0.00%> (ø)
src/cache/memcached.rs 0.00% <0.00%> (ø)
src/cache/redis.rs 0.00% <0.00%> (ø)
src/cache/s3.rs 55.35% <0.00%> (ø)
src/cache/webdav.rs 0.00% <0.00%> (ø)
src/compiler/clang.rs 51.14% <40.00%> (-1.00%) ⬇️
src/config.rs 28.65% <54.90%> (+1.88%) ⬆️
... and 1 more

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NobodyXu NobodyXu force-pushed the rm-openssl-for-debug-build branch from 93a8b64 to 6f97da5 Compare April 21, 2023 05:07
@NobodyXu
Copy link
Contributor Author

I've rebased against main, so this PR is now ready to merge.

@sylvestre
Copy link
Collaborator

Seems that it broke one of the Ubuntu test

@NobodyXu NobodyXu force-pushed the rm-openssl-for-debug-build branch from 6f97da5 to 199de56 Compare April 21, 2023 05:58
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Apr 21, 2023

Seems that it broke one of the Ubuntu test

Honestly, I have no idea why changing tls implementation would break dist_compiles.

@drahnr
Copy link
Collaborator

drahnr commented Apr 21, 2023

[2023-04-21T06:07:32Z WARN  sccache::dist::http::server] Res 9 error: assign job failed, job un-assigned from the server, caused by: POST to scheduler assign_job failed, caused by: error sending request for url (https://127.0.0.1:12345/api/v1/distserver/assign_job/1): error trying to connect: invalid peer certificate encoding, caused by: error trying to connect: invalid peer certificate encoding, caused by: invalid peer certificate encoding

I think a unit test might be in order to verify this more atomically

@NobodyXu NobodyXu changed the title Rm openssl pulled in linux Rm openssl pulled in linux debug build Apr 22, 2023
@NobodyXu NobodyXu changed the title Rm openssl pulled in linux debug build Rm openssl pulled in linux Apr 24, 2023
@NobodyXu NobodyXu mentioned this pull request Apr 24, 2023
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu force-pushed the rm-openssl-for-debug-build branch from 199de56 to 68aea4e Compare April 24, 2023 13:18
@NobodyXu
Copy link
Contributor Author

Superseded by #1742

@NobodyXu NobodyXu closed this Apr 24, 2023
@NobodyXu NobodyXu deleted the rm-openssl-for-debug-build branch April 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants