Stop feature dist-server from pulling in openssl #1738
Conversation
NobodyXu
force-pushed
the
rm-openssl-for-dist-server
branch
from
b4c8abd to
cfd4e2d
Compare
|
Build failure will be fixed once #1737 is merged |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
==========================================
+ Coverage 28.87% 29.11% +0.24%
==========================================
Files 49 49
Lines 17202 17446 +244
Branches 8268 8455 +187
==========================================
+ Hits 4967 5080 +113
- Misses 7221 7301 +80
- Partials 5014 5065 +51 see 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
The CI failure is caused by spki (pulled in pkcs1). Its msrv is 1.65 while currently sccache has a msrv of 1.64, thus requires a bump of msrv. |
- Replace direct `openssl` usage in sccache-dist/token_check.rs with `pkcs1` - Enable `rouille/rustls` instead of `rouille/ssl` to use rustls instead of openssl in tiny_http (dep of rouille). Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
force-pushed
the
rm-openssl-for-dist-server
branch
from
cfd4e2d to
b9b3595
Compare
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
|
Blocked on tomaka/rouille#272 |
|
I'd say porting to warp (see #1620 ) should avoid the issue and move to a more modern framework |
Thanks for the advice! |
|
I will close this PR for now. |
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
opensslusage in sccache-dist/token_check.rs withpkcs1rouille/rustlsinstead ofrouille/sslto use rustls instead of openssl in tiny_http (dep of rouille).opensslthat get pulled in debug buildSigned-off-by: Jiahao XU Jiahao_XU@outlook.com