nvcc: Correctly handle -ccbin argument given a directory #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Apr 24, 2023
| @@ -1,4 +1,5 @@ | |||
| // Copyright 2016 Mozilla Foundation | |||
| // SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
I am a bit confused why you are adding this ?
There was a problem hiding this comment.
Due to being an NVIDIA employee I am supposed to request files I modify have an NVIDIA copyright.
If this doesn't work for the sccache team, I am happy to remove the line.
There was a problem hiding this comment.
not a big deal but as nobody updates these values (which are probably useless anyway), I am surprised to see such changes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-ccbinargument to nvcc supports being passed either a compiler or the directory that holds the compiler.Mark these options as
PassThroughso that they are still considered as part of the hash.