Remove deprecated methods #1818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rPraml personally i'm fine with this - i fear somebody might to mention that so far you can use newer version as replacement without recompiling the old stuff. |
|
at least we should get rid of calling deprecated method from our own code |
|
I keep mulling this over -- how many things will we break by doing this -- and have we waited long enough for it to matter? Open to opinions and data on that! |
IMHO stuff that was deprecated in 1.8.0 can safely be removed if the next release is called 1.9.0 (or 2.0.0). Deprecated things are deprecated for a reason, after all. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would remove some deprecated methods, that were deprecated in this PR
a241104b#diff-ab1ca10bfcacde38d34848919eb3c5a3bf983f651a1a8867e9c525d7a9e4ef22 on on Feb 10, 2015
This encourages us to maintain clean and manageable code.
Since these methods have been deprecated for almost 10 years, I believe developers have had sufficient time to transition to alternative options.
I found one place, where bytecode relies on a deprecated method here
What do you think?