Make all service loading static #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the large performance regression of loading these classes from the classpath every time they are needed, and should cover existing use cases since all these features are designed to be configured statically by deciding which Rhino modules to use.
|
thanks, @gbrail will have a look at this during the next days... |
|
@gbrail have done a small test, looks like your change brings back the old performance. |
|
Yes, this one is a pretty simple one. Thanks for checking it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the large performance regression of loading these classes from the classpath every time they are needed, and should cover existing use cases since all these features are designed to be configured statically by deciding which Rhino modules to use.
@rbri I didn't see a big regression in standard benchmarks like the V8 benchmarks but I could imagine that in a use case with a lot of reflection that things could be much worse. This should fix it, please take a look!