Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to trigger sync in sync logs page #3558

Merged
merged 10 commits into from
Feb 26, 2025

Conversation

flodolo
Copy link
Collaborator

@flodolo flodolo commented Feb 8, 2025

Fixes #3557

@flodolo flodolo requested a review from mathjazz February 10, 2025 11:12
Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Left a few suggestions. Before we merge, I might want to make a small CSS change to account for adding the ability to disable sync in the future.

@flodolo
Copy link
Collaborator Author

flodolo commented Feb 11, 2025

Follow-up from earlier conversation: these are all the page using table-sort

pontoon/localizations/templates/localizations/widgets/resource_list.html
pontoon/projects/templates/projects/widgets/project_list.html
pontoon/sync/templates/sync/log_errors.html
pontoon/sync/templates/sync/log_list.html
pontoon/sync/templates/sync/log_project.html
pontoon/tags/templates/tags/widgets/tag_list.html
pontoon/teams/templates/teams/widgets/team_list.html

They all seem to already include table.css, so it would make sense to move all table-sort rules there. Happy to leave this to you ;-)

@flodolo flodolo force-pushed the sync_now_log branch 2 times, most recently from a644850 to af1038e Compare February 14, 2025 09:35
Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of minor changes. When and if we make more changes to the sync log, we'll adapt again if needed.

@flodolo Could you please take a look at the changes and test on stage?

@flodolo
Copy link
Collaborator Author

flodolo commented Feb 26, 2025

Changes look good (both stage and local instance) 👍🏼

@mathjazz mathjazz merged commit 1567437 into mozilla:main Feb 26, 2025
7 checks passed
@flodolo flodolo deleted the sync_now_log branch February 26, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow requesting manual sync from the sync log page
2 participants