-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to trigger sync in sync logs page #3558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Left a few suggestions. Before we merge, I might want to make a small CSS change to account for adding the ability to disable sync in the future.
547cb5e
to
3492f5d
Compare
Follow-up from earlier conversation: these are all the page using
They all seem to already include |
a644850
to
af1038e
Compare
af1038e
to
22faa00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of minor changes. When and if we make more changes to the sync log, we'll adapt again if needed.
@flodolo Could you please take a look at the changes and test on stage?
Changes look good (both stage and local instance) 👍🏼 |
Fixes #3557