-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Pin nightly #2335
ci: Pin nightly #2335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing though.
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to ef9e4dc. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to ef9e4dc. decode 4096 bytes, mask ff: No change in performance detected.time: [11.181 µs 11.214 µs 11.253 µs] change: [-0.4124% -0.0652% +0.2973%] (p = 0.73 > 0.05) decode 1048576 bytes, mask ff: No change in performance detected.time: [2.8876 ms 2.8972 ms 2.9082 ms] change: [-0.4753% +0.0511% +0.5632%] (p = 0.85 > 0.05) decode 4096 bytes, mask 7f: No change in performance detected.time: [19.535 µs 19.578 µs 19.629 µs] change: [-0.2555% +0.1160% +0.5499%] (p = 0.59 > 0.05) decode 1048576 bytes, mask 7f: No change in performance detected.time: [5.0713 ms 5.0847 ms 5.0997 ms] change: [-0.4410% -0.0417% +0.3670%] (p = 0.83 > 0.05) decode 4096 bytes, mask 3f: No change in performance detected.time: [5.5359 µs 5.5655 µs 5.6002 µs] change: [-0.8246% -0.1849% +0.3660%] (p = 0.57 > 0.05) decode 1048576 bytes, mask 3f: No change in performance detected.time: [1.4154 ms 1.4222 ms 1.4292 ms] change: [-0.4060% +0.1913% +0.8735%] (p = 0.57 > 0.05) coalesce_acked_from_zero 1+1 entries: No change in performance detected.time: [98.846 ns 99.160 ns 99.481 ns] change: [-0.2428% +0.2529% +0.7848%] (p = 0.33 > 0.05) coalesce_acked_from_zero 3+1 entries: No change in performance detected.time: [116.62 ns 116.94 ns 117.30 ns] change: [-0.3030% +0.0773% +0.4877%] (p = 0.72 > 0.05) coalesce_acked_from_zero 10+1 entries: No change in performance detected.time: [116.36 ns 116.74 ns 117.23 ns] change: [-0.5172% +0.3326% +1.2595%] (p = 0.50 > 0.05) coalesce_acked_from_zero 1000+1 entries: No change in performance detected.time: [97.137 ns 97.278 ns 97.429 ns] change: [-0.9701% -0.1223% +0.7525%] (p = 0.79 > 0.05) RxStreamOrderer::inbound_frame(): No change in performance detected.time: [111.26 ms 111.31 ms 111.36 ms] change: [-0.1435% -0.0692% -0.0021%] (p = 0.06 > 0.05) SentPackets::take_ranges: No change in performance detected.time: [5.4137 µs 5.5205 µs 5.6404 µs] change: [-16.352% -5.0630% +3.0796%] (p = 0.55 > 0.05) transfer/pacing-false/varying-seeds: No change in performance detected.time: [42.883 ms 42.964 ms 43.046 ms] change: [-0.4753% -0.2120% +0.0402%] (p = 0.12 > 0.05) transfer/pacing-true/varying-seeds: No change in performance detected.time: [43.147 ms 43.218 ms 43.289 ms] change: [-0.3981% -0.1601% +0.1000%] (p = 0.20 > 0.05) transfer/pacing-false/same-seed: Change within noise threshold.time: [42.928 ms 42.988 ms 43.049 ms] change: [+0.2140% +0.4186% +0.6263%] (p = 0.00 < 0.05) transfer/pacing-true/same-seed: Change within noise threshold.time: [43.305 ms 43.365 ms 43.424 ms] change: [-0.4091% -0.2116% -0.0144%] (p = 0.04 < 0.05) 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.time: [870.87 ms 880.68 ms 890.68 ms] thrpt: [112.27 MiB/s 113.55 MiB/s 114.83 MiB/s] change: time: [-2.3979% -0.8399% +0.7895%] (p = 0.30 > 0.05) thrpt: [-0.7833% +0.8470% +2.4568%] 1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.time: [300.28 ms 302.46 ms 304.69 ms] thrpt: [32.820 Kelem/s 33.062 Kelem/s 33.302 Kelem/s] change: time: [-1.0647% -0.0528% +0.9050%] (p = 0.92 > 0.05) thrpt: [-0.8969% +0.0528% +1.0762%] 1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold.time: [34.191 ms 34.350 ms 34.528 ms] thrpt: [28.962 elem/s 29.112 elem/s 29.248 elem/s] change: time: [-1.9124% -1.0565% -0.2243%] (p = 0.02 < 0.05) thrpt: [+0.2248% +1.0678% +1.9497%] 1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.time: [1.6830 s 1.7010 s 1.7193 s] thrpt: [58.164 MiB/s 58.790 MiB/s 59.418 MiB/s] change: time: [-1.0266% +0.3753% +1.8060%] (p = 0.60 > 0.05) thrpt: [-1.7740% -0.3739% +1.0373%] Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2335 +/- ##
==========================================
- Coverage 93.37% 93.34% -0.04%
==========================================
Files 114 114
Lines 36908 36908
Branches 36908 36908
==========================================
- Hits 34464 34451 -13
- Misses 1662 1675 +13
Partials 782 782 ☔ View full report in Codecov by Sentry. |
Due to rust-lang/rust#135235