Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(payments): upgrade @fluent/bundle to 0.16, @fluent/react to 0.1… #6291

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

chenba
Copy link
Contributor

@chenba chenba commented Aug 24, 2020

This is @stasm's PR #6098 (which is a follow-up to #6096/#6152) rebased on latest main.

Because

  • Fluent packages used to ship two build artifacts: index.js written in the most current ES version, and compat.js transpiled to ES2017. In Remove compat.js build artifacts projectfluent/fluent.js#472 we removed the compat.js builds and set tsc to target ES2018.
  • I didn't think it was appropriate for upstream Fluent to make the decision about the browsers supported by the compat.js builds. It's something that app developers should have more control over.
  • The expectation is that apps using Fluent will be able to transpile node_modules dependencies to match their browser compatibility requirements.

This pull request

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).

@chenba chenba requested a review from a team August 24, 2020 23:51
@chenba chenba merged commit 7978f63 into mozilla:main Aug 25, 2020
@chenba chenba deleted the pr/stasm/6098 branch August 25, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants