Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Unpack zip files that contain a single folder with a manifest.json file #15375

Open
1 task
abyrne-moz opened this issue Feb 18, 2025 · 4 comments
Open
1 task
Labels

Comments

@abyrne-moz
Copy link

abyrne-moz commented Feb 18, 2025

Description

For an add-on to be accepted via our developer tools, we require the manifest.json file to be at the top level of the zip file. Unfortunately many OSs and Zip handlers package the entire folder/directory inside the archive.

It would be helpful if we could detect if the zip file contains a single directory, with valid add-on files, and could handle this appropriately.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@wagnerand
Copy link
Member

wagnerand commented Feb 18, 2025

This would be a break of the spec. What is the return on invest if other stores do not do the same?

@abyrne-moz
Copy link
Author

I feel like it would improve the experience of first time extension developers.

@abyrne-moz
Copy link
Author

if other stores do not do the same?

FWIW, the chrome web store does exactly the behaviour that is proposed on this task if you upload a ZIP file with a folder inside.

@diox
Copy link
Member

diox commented Feb 18, 2025

We repack the zip uploaded first anyway so we could do that transparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants