manifest.json was not found

[Hiruto1337]

I am told by the linter that my decompressed .zip file doesn't contain a manifest.json file. But it does.

[Rob--W]

The manifest.json file must be at the top level, not in a subdirectory.

[wagnerand]

@abyrne-moz Perhaps we should improve the error message to explicitly call this out, like:

"manifest.json was not found at the top-level of the submitted file".

[willdurand]

"manifest.json was not found at the top-level of the submitted file".

FWIW this is already described in the full message (each linter notice/warning/error has a short message and a long description) -

addons-linter/src/messages/layout.js

Lines 35 to 41 in 883a496

	export const TYPE_NO_MANIFEST_JSON = {
	code: 'TYPE_NO_MANIFEST_JSON',
	message: i18n._('manifest.json was not found'),
	description: i18n._(`No manifest.json was found at the root of the extension.
	The package file must be a ZIP of the extension's files themselves, not of the
	containing directory. See: https://mzl.la/2r2McKv for more on packaging.`),
	};

[wagnerand]

Yes, and not everyone might click into the full report.

[Hiruto1337]

It didn't help that on MacOS, you have to zip your files via the Terminal in order for the .zip file not to automatically create a new parent directory

[abyrne-moz]

I would prefer to see this issue resolved by detecting if there was a single directory within the ZIP file with a valid manifest.json file and we just handle it correctly internally.