Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Latest Version" Block from Add-on Version History for Langpacks #13155

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

chrstinalin
Copy link
Contributor

@chrstinalin chrstinalin commented Aug 14, 2024

Fixes mozilla/addons#14942

Removes the 'latest version' block and replaces the 'older versions' block with a full version history for langpacks.

Before
image

After
image

@chrstinalin chrstinalin marked this pull request as draft August 14, 2024 08:28
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (a790d93) to head (d4aa568).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13155   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         267      267           
  Lines       10593    10600    +7     
  Branches     3220     3225    +5     
=======================================
+ Hits        10412    10419    +7     
  Misses        168      168           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrstinalin chrstinalin force-pushed the #14942-version-history branch from 1164a23 to ac2e183 Compare August 19, 2024 13:43
@chrstinalin chrstinalin marked this pull request as ready for review August 19, 2024 13:50
@chrstinalin chrstinalin requested review from a team and eviljeff and removed request for a team August 19, 2024 13:50
@chrstinalin chrstinalin marked this pull request as draft August 19, 2024 13:51
@eviljeff
Copy link
Member

We just want this change for language packs - for other types of add-on the existing behaviour should remain.

@chrstinalin chrstinalin force-pushed the #14942-version-history branch from c5d33de to 7d2da7b Compare August 19, 2024 14:54
@chrstinalin chrstinalin marked this pull request as ready for review August 19, 2024 15:24
@chrstinalin chrstinalin changed the title Removed "Latest Version" Block from Add-on Version History Removed "Latest Version" Block from Add-on Version History for Langpacks Aug 19, 2024
@chrstinalin chrstinalin merged commit fcb44c7 into mozilla:master Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: newer versions listed as older versions
2 participants