Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBS-486: remove legacy elasticsearch #6906

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

relud
Copy link
Member

@relud relud commented Feb 11, 2025

No description provided.

@relud relud force-pushed the relud-obs-486-remove-legacy-es branch 3 times, most recently from 517b233 to 27c8883 Compare February 11, 2025 17:35
@willkg
Copy link
Contributor

willkg commented Feb 11, 2025

We need to remove some other lines:

$ rg LEGACY_ELASTICSEARCH
bin/waitfor_services.sh
16:waitfor --verbose "${LEGACY_ELASTICSEARCH_URL}"

bin/test.sh
22:LEGACY_ELASTICSEARCH_URL="${LEGACY_ELASTICSEARCH_URL:-}"

@relud relud force-pushed the relud-obs-486-remove-legacy-es branch from 27c8883 to 6bf3cd7 Compare February 11, 2025 17:41
@willkg
Copy link
Contributor

willkg commented Feb 11, 2025

Nevermind--you got them!

@relud relud force-pushed the relud-obs-486-remove-legacy-es branch 3 times, most recently from 4d9fa90 to ae4f74c Compare February 11, 2025 17:55
@relud relud force-pushed the relud-obs-486-remove-legacy-es branch from ae4f74c to b9a48a9 Compare February 11, 2025 17:56
@relud relud marked this pull request as ready for review February 11, 2025 18:03
@relud relud requested a review from a team as a code owner February 11, 2025 18:03
Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through local dev environment workflows: build, setup, run, test, etc. I also searched across the codebase for some things that were removed.

Some docs we should update:

socorro/external/es/crashstorage.py
292:    # have been tested with Elasticsearch 1.4.

docs/crashstorage.rst
70:Socorro currently requires Elasticsearch version 1.4.
241:See `Elasticsearch 1.4 mapping documentation
242:<https://www.elastic.co/guide/en/elasticsearch/reference/1.4/mapping.html>`_.

webapp/crashstats/documentation/jinja2/docs/supersearch/home.html
274:          <td>The field value matches the given regular expression. The accepted syntax is described in the <a href="https://www.elastic.co/guide/en/elasticsearch/reference/1.4/query-dsl-regexp-query.html#regexp-syntax">Elasticsearch documentation</a>.</td>

webapp/crashstats/documentation/jinja2/docs/supersearch/examples.html
131:      href="https://www.elastic.co/guide/en/elasticsearch/reference/1.4/query-dsl-regexp-query.html#regexp-syntax">Elasticsearch

Otherwise, this looks good plus it's soooo nice that building and running tests is much faster now.

r+wc

@relud relud enabled auto-merge February 11, 2025 18:38
@relud relud added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 0e54be0 Feb 11, 2025
1 check passed
@relud relud deleted the relud-obs-486-remove-legacy-es branch February 11, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants