Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports moveit1 #3689 (backport #3357) #3365

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 27, 2025

Description

Ports moveit/moveit#3689, which avoids blocking the publishing of planning scenes during long operations, by copying planning scenes rather than locking the planning scene monitor.

Please backport to humble and jazzy when merged.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3357 done by [Mergify](https://mergify.com).

* Renames .hpp files to .h to help cherry pick.

* Publish planning scene while planning (#3689)

So far, the PSM's planning scene was locked during planning, thus stopping any PS updates in rviz.
Instead of locking the PSM's current scene, we use an independent clone of that scene for planning. To this end, PlanningSceneMonitor::copyPlanningScene() and ExecutableMotionPlan::copyPlanningScene() were added.

* Renames .h files back to .hpp.

* Updates message types to ros2.

* Updates to use new variable names.

* Undoes erroneous autoformatting.

(cherry picked from commit e2b24f5)
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 44.41%. Comparing base (ce3720c) to head (e9a5bdf).
Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
...nning_scene_monitor/src/planning_scene_monitor.cpp 0.00% 8 Missing ⚠️
...rc/default_capabilities/move_action_capability.cpp 0.00% 4 Missing ⚠️
..._motion_planner/src/move_group_sequence_action.cpp 0.00% 3 Missing ⚠️
...lude/moveit/plan_execution/plan_representation.hpp 0.00% 3 Missing ⚠️
...motion_planner/src/move_group_sequence_service.cpp 0.00% 2 Missing ⚠️
...ros/planning/moveit_cpp/src/planning_component.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3365      +/-   ##
==========================================
+ Coverage   44.40%   44.41%   +0.01%     
==========================================
  Files         701      701              
  Lines       61866    61864       -2     
  Branches     7494     7494              
==========================================
+ Hits        27466    27469       +3     
+ Misses      34232    34227       -5     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rr-mark rr-mark mentioned this pull request Mar 6, 2025
6 tasks
@sea-bass sea-bass merged commit e221d64 into jazzy Mar 6, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3357 branch March 6, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants