fix: explicitly add the same namespace as the parent node #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3360 +/- ##
==========================================
- Coverage 46.25% 45.84% -0.41%
==========================================
Files 717 717
Lines 62596 62577 -19
Branches 7568 7564 -4
==========================================
- Hits 28947 28681 -266
- Misses 33482 33729 +247
Partials 167 167 ☔ View full report in Codecov by Sentry. |
|
Thank you! A small formatting fix is needed, but otherwise looks good. |
sea-bass
approved these changes
Feb 22, 2025
rr-mark
approved these changes
Feb 25, 2025
|
@sea-bass |
sea-bass
added
the
backport-jazzy
Added the label! Sorry I missed that. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* fix: explicitly add the same namespace as the parent node * reformat * reformat (cherry picked from commit bbf7e40)
6 tasks
sea-bass
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
When launching the
move_groupnode with a namespace and runningmoveit_pywithin a node that has the same namespace, themoveit_simple_controller_managerlacked a namespace. As a result, the robot could not operate because the action for trajectory execution was missing the necessary namespace.Solution
Explicitly added the parent node's namespace.
Checklist