Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect robot alpha value in trail trajectory visual #3353

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

flbeck
Copy link
Contributor

@flbeck flbeck commented Feb 19, 2025

Description

The motion planning plugin in RViz does not respect the alpha values for attached bodies when visualizing the trail of the planned path. The alpha values of the trail are only updated if the attached body color is changed at a later point.

Updating the attached body color upon creation of the trail fixes this problem. The same thing applies to drawing the robot along the planned path which is handeled in the update function.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sea-bass sea-bass added backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy labels Feb 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.23%. Comparing base (bb2eb75) to head (f3ddd4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ugin_render_tools/src/trajectory_visualization.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
+ Coverage   45.84%   46.23%   +0.39%     
==========================================
  Files         717      717              
  Lines       62573    62596      +23     
  Branches     7564     7564              
==========================================
+ Hits        28680    28932     +252     
+ Misses      33726    33498     -228     
+ Partials      167      166       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr added this pull request to the merge queue Feb 21, 2025
Merged via the queue into moveit:main with commit 83d05ae Feb 21, 2025
9 checks passed
mergify bot pushed a commit that referenced this pull request Feb 21, 2025
Co-authored-by: Florian Beck <f.beck@palfinger.com>
(cherry picked from commit 83d05ae)
mergify bot pushed a commit that referenced this pull request Feb 21, 2025
Co-authored-by: Florian Beck <f.beck@palfinger.com>
(cherry picked from commit 83d05ae)
sea-bass pushed a commit that referenced this pull request Feb 22, 2025
Co-authored-by: Florian Beck <f.beck@palfinger.com>
(cherry picked from commit 83d05ae)

Co-authored-by: Florian Beck <florian.beck@tuwien.ac.at>
sea-bass pushed a commit that referenced this pull request Feb 26, 2025
Co-authored-by: Florian Beck <f.beck@palfinger.com>
(cherry picked from commit 83d05ae)

Co-authored-by: Florian Beck <florian.beck@tuwien.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants