Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print links in collision #2727

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

Abishalini
Copy link
Contributor

Description

The CheckStartStateCollision adapter does return failure when links are in collision but it currently does not say which links are in collision. This PR adds the links in collision to the MoveItErrorCode message so it can help with debugging.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 42.98%. Comparing base (d962501) to head (0ffe748).
Report is 17 commits behind head on main.

Files Patch % Lines
...dapter_plugins/src/check_start_state_collision.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
- Coverage   50.74%   42.98%   -7.76%     
==========================================
  Files         392      692     +300     
  Lines       32553    56333   +23780     
  Branches        0     7273    +7273     
==========================================
+ Hits        16517    24210    +7693     
- Misses      16036    31962   +15926     
- Partials        0      161     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abishalini Abishalini requested a review from sjahr March 5, 2024 15:18
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be helpful for debugging, thanks!

@sjahr sjahr merged commit aeb03f7 into moveit:main Mar 5, 2024
11 of 12 checks passed
@Abishalini Abishalini deleted the pr-print-links-in-collision branch March 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants