Get configuration values of traj_exec_man

[MatthijsBurgh]

Description

Get configuration values of the trajectory_execution_mananager

Checklist

• Required by CI: Code is auto formatted using clang-format
• Extend the tutorials / documentation reference
• Document API changes relevant to the user in the MIGRATION.md notes
• Create tests, which fail without this PR reference
• Include a screenshot if changing a GUI
• While waiting for someone to review your request, please help review another open pull request to support the maintainers

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 42.61%. Comparing base (d962501) to head (d645611).
Report is 14 commits behind head on main.

❗ Current head d645611 differs from pull request most recent head f4d1718. Consider uploading reports for the commit f4d1718 to get more accurate results

Files	Patch %	Lines
...ution_manager/src/trajectory_execution_manager.cpp	0.00%	12 Missing ⚠️
...execution_manager/trajectory_execution_manager.cpp	0.00%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2702      +/-   ##
==========================================
- Coverage   50.74%   42.61%   -8.12%     
==========================================
  Files         392      692     +300     
  Lines       32553    56319   +23766     
  Branches        0     7270    +7270     
==========================================
+ Hits        16517    23997    +7480     
- Misses      16036    32159   +16123     
- Partials        0      163     +163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tylerjw]

I'm happy with this PR but to keep clang-tidy happy, would you mind renaming the new methods you added to keep with the style asked for by our config?

Here is an excerpt from the failing CI job.

/home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_ros/planning/trajectory_execution_manager/include/moveit/trajectory_execution_manager/trajectory_execution_manager.h:197:8: warning: invalid case style for method 'ExecutionDurationMonitoring' [readability-identifier-naming]
    bool ExecutionDurationMonitoring() const;
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         executionDurationMonitoring
  /home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_ros/planning/trajectory_execution_manager/src/trajectory_execution_manager.cpp:258:34: note: FIX-IT applied suggested code changes
  bool TrajectoryExecutionManager::ExecutionDurationMonitoring() const
                                   ^
  /home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_ros/planning/trajectory_execution_manager/include/moveit/trajectory_execution_manager/trajectory_execution_manager.h:197:8: note: FIX-IT applied suggested code changes
    bool ExecutionDurationMonitoring() const;
         ^

[MatthijsBurgh]

I did run the pre-commit, but that didn't notify me/fix it. Could you maybe extend the pre-commit config, so this would show up before committing?

I will update the PR manually for now.

[MatthijsBurgh]

@tylerjw See https://github.com/pocc/pre-commit-hooks for a clang-tidy hook. Also listed on the 'official' pre-commit hooks list

[tylerjw]

We've tried running clang-tidy in pre-commit but sadly it takes so long to execute it is really annoying for most people. Also, it depends on you having compiled the code with clang.

I wish I had a better solution than running it in CI.