Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moveit::core::error_msg_to_string in Humble #2689

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

reidchristopher
Copy link

Description

Update moveit::core::error_msg_to_string to match updates to moveit_msgs/msg/MoveItErrorCodes.msg. Simply pulled down the file from Iron.

Fixes #2688

Copy link

mergify bot commented Feb 15, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@reidchristopher reidchristopher changed the title Update moveit::core::error_msg_to_string Update moveit::core::error_msg_to_string in Humble Feb 16, 2024
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this fix!

@sjahr sjahr linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ce2fa9) 50.90% compared to head (8d6aaea) 50.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2689      +/-   ##
==========================================
+ Coverage   50.90%   50.91%   +0.02%     
==========================================
  Files         382      382              
  Lines       31897    31897              
==========================================
+ Hits        16234    16238       +4     
+ Misses      15663    15659       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henningkayser henningkayser merged commit 4c8e353 into moveit:humble Feb 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moveit::core::error_code_to_string broken in Humble
3 participants