-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up hybrid planning package #2603
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
- Coverage 51.18% 50.73% -0.44%
==========================================
Files 393 392 -1
Lines 32753 32553 -200
==========================================
- Hits 16760 16513 -247
- Misses 15993 16040 +47 ☔ View full report in Codecov by Sentry. |
This pull request is in conflict. Could you fix it @sjahr? |
..._planning_manager_component/include/moveit/hybrid_planning_manager/planner_logic_interface.h
Show resolved
Hide resolved
...ing/hybrid_planning_manager/hybrid_planning_manager_component/res/hp_manager_parameters.yaml
Outdated
Show resolved
Hide resolved
..._planning_manager_component/include/moveit/hybrid_planning_manager/hybrid_planning_manager.h
Show resolved
Hide resolved
# Conflicts: # moveit_ros/hybrid_planning/test/hybrid_planning_demo_node.cpp # moveit_ros/hybrid_planning/test/launch/hybrid_planning_common.py
65f0b85
to
e545129
Compare
...ing/hybrid_planning_manager/hybrid_planning_manager_component/res/hp_manager_parameters.yaml
Outdated
Show resolved
Hide resolved
…ning_manager_component/res/hp_manager_parameters.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cleanup looks really good! I left some suggestions about the parameters, otherwise lgtm
..._planning_manager_component/include/moveit/hybrid_planning_manager/hybrid_planning_manager.h
Outdated
Show resolved
Hide resolved
...ng/hybrid_planning_manager/hybrid_planning_manager_component/src/hybrid_planning_manager.cpp
Show resolved
Hide resolved
...local_planner/local_planner_component/include/moveit/local_planner/local_planner_component.h
Outdated
Show resolved
Hide resolved
moveit_ros/hybrid_planning/test/config/common_hybrid_planning_params.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Description
Checklist