Enable iron build jobs in CI

[henningkayser]

I thought we had done this already for main, but obviously this was not the case. Iron should also be enforced for PRs.

failing tests

[sea-bass]

Seems like the failing test is doing rclcpp::init() and creating an rclcpp::Logger instance even though neither is being used.

This can be removed for this test, but there likely will be more instances like these.

[henningkayser]

Seems like the failing test is doing rclcpp::init() and creating an rclcpp::Logger instance even though neither is being used.

This can be removed for this test, but there likely will be more instances like these.

My take is that we might want to rerun this on a fresh set of iron images.

[sea-bass]

Sounds good. And actually, that failing test does require rclcpp under the hood in an included test fixture, it just wasn't immediately visible from only looking at the file.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.02%. Comparing base (d962501) to head (581589f).
Report is 25 commits behind head on main.

❗ Current head 581589f differs from pull request most recent head 065602a. Consider uploading reports for the commit 065602a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2420      +/-   ##
==========================================
- Coverage   50.74%   43.02%   -7.72%     
==========================================
  Files         392      692     +300     
  Lines       32553    56295   +23742     
  Branches        0     7272    +7272     
==========================================
+ Hits        16517    24213    +7696     
- Misses      16036    31920   +15884     
- Partials        0      162     +162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

[sea-bass]

@henningkayser I saw this sitting around and updated / re-ran CI under the assumption that it should work by now (i.e., half a year later).

EDIT: Seems there are some MoveIt Servo tests failing. Either there is an Iron specific issue or something needs a backport. I will choose to not investigate this one myself.

One question though: I notice that with this PR both humble and iron also add a -testing image, but the Jazzy CI does not. Should this also add that?

[sea-bass]

Iron's about to go EOL, so it's probably not worth putting this in at this point.