Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kasiah/community dot com connector #1112
Kasiah/community dot com connector #1112
Changes from 32 commits
7f4241f
277b159
439d053
bc49be2
efbf3d4
657b86e
528e2df
27dbb09
d0a31bd
bd593ce
c8438e9
bbc1518
71489d9
48fb07a
98fec87
5b9e0d6
ed8e712
b62a481
fc2551e
4f27edc
36b0651
d052f40
83f8674
126453a
8877778
2ae666f
d868766
ab5b88f
d07daab
96af8fa
82576c6
0e6667d
22f8841
5d6c17c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks okay to me, I'm curious about the reasoning? That will help me understand how big the breaking change would be - right now this code is so similar that it's hard to tell how it might cause problems for downstream users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning for the change is that something about how our Parsons operator is working is changing the attributes of the CSVView, and we just need to do the
to_csv
instead of getting the filename. It would presumably break for someone if they want it to fail when encountering an Attribute Error. I assume this is unlikely and that this probably wouldn't really break anything for anyone, but technically if someone is depending on getting an AttributeError in some case, this would mean they instead get an actual table. Not sure why that would be a problem, but trying to be proactive!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay gotcha, that makes sense. Yeah, it's hard to imagine someone depending on getting an error there - there's no reason to call the function at all if you error out there. It hasn't uploaded the data to the blob yet, and it's not saving anything on the object that you can access, so there's no reason to call the function and catch the attribute error unless you're checking if
table.table.source.filename
exists, doing something, then calling the function again. But that would be a very weird pattern, like you could literally just check iftable.table.source.filename
exists directly. So yes, this is technically a breaking change but I think the chances of anyone being bothered by it are very very small so we are okay to merge it into main instead of major release.