Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If petl is loaded from a CSV, use the source file, don't re-write #1062

Merged
merged 2 commits into from
Jun 6, 2024
Merged

If petl is loaded from a CSV, use the source file, don't re-write #1062

merged 2 commits into from
Jun 6, 2024

Conversation

austinweisgrau
Copy link
Collaborator

No need to rewrite a CSV for a non-transformed petl that was loaded from a CSV on disk.

This can save a lot of time when working with large CSVs

shaunagm
shaunagm reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this, just want to get a little clarification on how this works (and possibly have that clarification as a code comment, if you agree that it would be helpful)

@shaunagm shaunagm self-assigned this Jun 6, 2024
@austinweisgrau
If petl is loaded from a CSV, use the source file, don't re-write
ff8b599 
No need to rewrite a CSV for a non-transformed petl that was loaded
from a CSV on disk.
@austinweisgrau
Add comment explaining CSVView instance check
1ca3134
shaunagm
shaunagm approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick clarification and for adding the comment! I'll merge once the tests pass again.

@shaunagm shaunagm merged commit bea810c into move-coop:main Jun 6, 2024
14 checks passed
@austinweisgrau austinweisgrau deleted the petl_csv branch June 6, 2024 20:59
@austinweisgrau austinweisgrau mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunagm shaunagm shaunagm approved these changes

Assignees

@shaunagm shaunagm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinweisgrau @shaunagm