More StreamPayment config #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
a0-pleasereview
WASM runtime size check:Compared to target branchdancebox runtime: 1428 KB (no changes) ✅ flashbox runtime: 840 KB (no changes) ✅ dancelight runtime: 2188 KB (no changes) ✅ container chain template simple runtime: 1132 KB (no changes) ✅ container chain template frontier runtime: 1416 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master jeremy-more-stream-payment-configs +/- ##
======================================================================
+ Coverage 65.40% 65.57% +0.17%
+ Files 350 351 +1
+ Lines 60856 61165 +309
======================================================================
+ Hits 39798 40105 +307
+ Misses 21058 21060 +2
|
girazoki
reviewed
Feb 25, 2025
girazoki
approved these changes
Feb 25, 2025
girazoki
reviewed
Feb 25, 2025
girazoki
reviewed
Feb 25, 2025
girazoki
requested changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new config items:
minimum_request_deadline_delay: currently stream parties can create a mandatory change request with an immediate/very close deadline, which can allow for the payer to stop paying immediately. This new item allows to set a minimal delay (in the stream time unit) so that the other party have fair time to respond.soft_minimum_deposit: Allows to configure a minimum amount of deposit when the stream source change it manually. It also prevents the source to close the stream if not stalled. This allows to guarantee to the target that payment will still occur for at leastsoft_minimum_deposit / ratetime, and prevents the stream to be closed/emptied by surprise. This can be useful for non-automated services that could need time to prepare and react to the end of the service.Breaking changes
This changes the
StreamConfigstruct stored in this pallet but also in DataPreservers pallets as a config can be stored in a profile if the preserver wishes to provide services in exchange for a specific stream payment.TODOs: