Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new optional param classInstance to Serializer and Deserializer helper classes #5

Merged
merged 2 commits into from
Jan 19, 2017
Merged

added new optional param classInstance to Serializer and Deserializer helper classes #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0799faa
added new optional param `classInstance` to `Serializer` and `Deseria…
Jan 16, 2017
e494ad6
adding documentation + suggested parameter/alias name changes
Jan 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions kafka-0.10.x/src/main/scala/monix/kafka/Deserializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,18 @@ import language.existentials
*/
final case class Deserializer[A](
className: String,
classType: Class[_ <: KafkaDeserializer[A]]) {
classType: Class[_ <: KafkaDeserializer[A]],
classInstance: Deserializer.ClassInstanceProvider[A] = (d: Deserializer[A]) => d.classType.newInstance()) {

/** Creates a new instance. */
def create(): KafkaDeserializer[A] =
classType.newInstance()
classInstance(this)
}

object Deserializer {

type ClassInstanceProvider[A] = (Deserializer[A]) => KafkaDeserializer[A]

implicit val forStrings: Deserializer[String] =
Deserializer(
className = "org.apache.kafka.common.serialization.StringDeserializer",
Expand Down
8 changes: 6 additions & 2 deletions kafka-0.10.x/src/main/scala/monix/kafka/Serializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,18 @@ import language.existentials
*/
final case class Serializer[A](
className: String,
classType: Class[_ <: KafkaSerializer[A]]) {
classType: Class[_ <: KafkaSerializer[A]],
classInstance: Serializer.ClassInstanceProvider[A] = (s: Serializer[A]) => s.classType.newInstance()) {

/** Creates a new instance. */
def create(): KafkaSerializer[A] =
classType.newInstance()
classInstance(this)
}

object Serializer {

type ClassInstanceProvider[A] = (Serializer[A]) => KafkaSerializer[A]

implicit val forStrings: Serializer[String] =
Serializer(
className = "org.apache.kafka.common.serialization.StringSerializer",
Expand Down
19 changes: 13 additions & 6 deletions kafka-0.8.x/src/main/scala/monix/kafka/Deserializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,26 @@ import language.existentials
*/
final case class Deserializer[A](
className: String,
classType: Class[_ <: KafkaDecoder[A]]) {
classType: Class[_ <: KafkaDecoder[A]],
classInstance: Deserializer.ClassInstanceProvider[A] = Deserializer.reflectCreate[A] _) {

/** Creates a new instance. */
def create(): KafkaDecoder[A] = {
val constructor = classType.getDeclaredConstructors()(0)
def create(): KafkaDecoder[A] =
classInstance(this)
}

object Deserializer {

type ClassInstanceProvider[A] = (Deserializer[A]) => KafkaDecoder[A]

private def reflectCreate[A](d: Deserializer[A]): KafkaDecoder[A] = {
val constructor = d.classType.getDeclaredConstructors()(0)
constructor.getParameterCount match {
case 0 => classType.newInstance()
case 0 => d.classType.newInstance()
case 1 => constructor.newInstance(null).asInstanceOf[KafkaDecoder[A]]
}
}
}

object Deserializer {
implicit val forStrings: Deserializer[String] =
Deserializer(
className = "kafka.serializer.StringDecoder",
Expand Down
8 changes: 6 additions & 2 deletions kafka-0.8.x/src/main/scala/monix/kafka/Serializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,18 @@ import language.existentials
*/
final case class Serializer[A](
className: String,
classType: Class[_ <: KafkaSerializer[A]]) {
classType: Class[_ <: KafkaSerializer[A]],
classInstance: Serializer.ClassInstanceProvider[A] = (s: Serializer[A]) => s.classType.newInstance()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default parameter looks ugly (personal pet peeve). I'm fairly certain that Scala accepts this:

classInstance: Serializer.ClassInstanceProvider[A] = _.classType.newInstance()

While we are at it classInstance: Serializer.ClassInstanceProvider is a little redundant and verbose. So lets simplify to:

constructor: Serializer.Constructor[A] = _.classType.newInstance()

// ... 

object Serializer {
  type Constructor[A] = (Serializer[A]) => KafkaSerializer[A]
  // ...

Naming, right? :-) I don't care that much, so it's up to you.


/** Creates a new instance. */
def create(): KafkaSerializer[A] =
classType.newInstance()
classInstance(this)
}

object Serializer {

type ClassInstanceProvider[A] = (Serializer[A]) => KafkaSerializer[A]

implicit val forStrings: Serializer[String] =
Serializer(
className = "org.apache.kafka.common.serialization.StringSerializer",
Expand Down
8 changes: 6 additions & 2 deletions kafka-0.9.x/src/main/scala/monix/kafka/Deserializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,18 @@ import language.existentials
*/
final case class Deserializer[A](
className: String,
classType: Class[_ <: KafkaDeserializer[A]]) {
classType: Class[_ <: KafkaDeserializer[A]],
classInstance: Deserializer.ClassInstanceProvider[A] = (d: Deserializer[A]) => d.classType.newInstance()) {

/** Creates a new instance. */
def create(): KafkaDeserializer[A] =
classType.newInstance()
classInstance(this)
}

object Deserializer {

type ClassInstanceProvider[A] = (Deserializer[A]) => KafkaDeserializer[A]

implicit val forStrings: Deserializer[String] =
Deserializer(
className = "org.apache.kafka.common.serialization.StringDeserializer",
Expand Down
8 changes: 6 additions & 2 deletions kafka-0.9.x/src/main/scala/monix/kafka/Serializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,18 @@ import language.existentials
*/
final case class Serializer[A](
className: String,
classType: Class[_ <: KafkaSerializer[A]]) {
classType: Class[_ <: KafkaSerializer[A]],
classInstance: Serializer.ClassInstanceProvider[A] = (s: Serializer[A]) => s.classType.newInstance()) {

/** Creates a new instance. */
def create(): KafkaSerializer[A] =
classType.newInstance()
classInstance(this)
}

object Serializer {

type ClassInstanceProvider[A] = (Serializer[A]) => KafkaSerializer[A]

implicit val forStrings: Serializer[String] =
Serializer(
className = "org.apache.kafka.common.serialization.StringSerializer",
Expand Down