MONGOID-5820 Fix the session object leak when using transactions (#5878…

…) (#5893)

Co-authored-by: Valerii Goncharenko <virusx777@gmail.com>

lib/mongoid/clients/sessions.rb

@@ -62,6 +62,7 @@ def with_session(options = {})
         rescue *transactions_not_supported_exceptions
           raise Mongoid::Errors::TransactionsNotSupported
         ensure
+          Threaded.clear_modified_documents(session)
           Threaded.clear_session(client: persistence_context.client)
         end
 

lib/mongoid/threaded.rb

@@ -18,6 +18,7 @@ module Threaded
     CURRENT_SCOPE_KEY = '[mongoid]:current-scope'
 
     AUTOSAVES_KEY = '[mongoid]:autosaves'
+
     VALIDATIONS_KEY = '[mongoid]:validations'
 
     STACK_KEYS = Hash.new do |hash, key|
@@ -376,9 +377,7 @@ def add_modified_document(session, document)
     # @return [ Set<Mongoid::Document> ] Collection of modified documents before
     #   it was cleared.
     def clear_modified_documents(session)
-      modified_documents[session].dup
-    ensure
-      modified_documents[session].clear
+      modified_documents.delete(session) || []
     end
 
     # Queries whether document callbacks should be executed by default for the

spec/mongoid/threaded_spec.rb

@@ -341,4 +341,23 @@
       end
     end
   end
+
+  describe '#clear_modified_documents' do
+    let(:session) do
+      double(Mongo::Session).tap do |session|
+        allow(session).to receive(:in_transaction?).and_return(true)
+      end
+    end
+
+    context 'when there are modified documents' do
+      before do
+        described_class.add_modified_document(session, Minim.new)
+        described_class.clear_modified_documents(session)
+      end
+
+      it 'removes the documents and keys' do
+        expect(described_class.modified_documents).to be_empty
+      end
+    end
+  end
 end