Increase connection timeouts to allow using Atlas shared clusters #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Nov 13, 2024
tests/ConnectionTest.php
Outdated
| 'connectTimeoutMS' => 100, | ||
| 'serverSelectionTimeoutMS' => 250, | ||
| 'connectTimeoutMS' => 1000, | ||
| 'serverSelectionTimeoutMS' => 1000, |
There was a problem hiding this comment.
I'd suggest using a slightly higher value here, as it's intended to outlast a replica set election. Replica Set Elections still notes that an election should not exceed 12 seconds, but I think you'd be OK to just throw another zero on this and use 10. If that's still too much, I'd at least consider bumping it to 5 or 6 seconds.
But using the same value as connectTimeoutMS may send the wrong message to any users that come across this. The connection timeout should logically be a smaller value.
There was a problem hiding this comment.
Ok. I've set serverSelectionTimeoutMS to 6000ms.
jmikola
approved these changes
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasted far too much time trying to run the tests using an Atlas M0 cluster. It turned out that the error was due to a delay too short to allow the connection.