DOCSP-44172: Laravel Herd #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmorisi
requested changes
Oct 11, 2024
Comment on lines
31
to
35
| .. tip:: | ||
|
|
||
| Alternatively, you can use Laravel Herd to install MongoDB and configure a | ||
| Laravel MongoDB development environment. For more information about using | ||
| Laravel Herd with MongoDB, see the following resources: |
There was a problem hiding this comment.
This admonition box leads with "Alternatively..." before introducing any of the dependencies in the main body of the page. Would consider either moving this tip box lower or updating the text to the following.
Let me know if you'd like to talk more about this feedback!
Suggested change
| .. tip:: | |
| Alternatively, you can use Laravel Herd to install MongoDB and configure a | |
| Laravel MongoDB development environment. For more information about using | |
| Laravel Herd with MongoDB, see the following resources: | |
| .. tip:: | |
| As an alternative to the steps detailed on this page, you can use Laravel Herd to install MongoDB and configure a | |
| Laravel MongoDB development environment. For more information about using | |
| Laravel Herd with MongoDB, see the following resources: |
There was a problem hiding this comment.
I kept the admonition where it is but reworded - lmk what you think!
GromNaN
approved these changes
Oct 11, 2024
rustagir
approved these changes
Oct 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://jira.mongodb.org/browse/DOCSP-44172
Staging - https://deploy-preview-143--docs-laravel.netlify.app/quick-start/download-and-install/
Checklist