Fix nested dates format

[alexsmko]

#2129

[divine]

Hello,

This looks like a breaking change for the projects depending on the old behavior, however, on the other hand, this is definitely a fix.

@Smolevich what do you think?

Thanks!

[shaedrich]

Your change works for EmbedsOne but not for EmbedsMany since Arr::has()/Arr::set() doesn't support dot-syntax on nested arrays (entry.*.date). Interestingly, array_get()/array_set() do. So I'd add this to make it work for both EmbedsOne and EmbedsMany:

Suggested change

	foreach ($this->getDates() as $key) {
	foreach ($this->getDates() as $key) {
	$res = data_get($attributes, $key);
	if (is_array($res)) {
	$res = array_filter($res);
	}
	if (Str::contains($key, '.') && Arr::has($attributes, $key)) {
	Arr::set($attributes, $key, $this->serializeDate(
	$this->asDateTime(Arr::get($attributes, $key))
	));
	} else if (Str::contains($key, '.') && !empty($res)) {
	data_set($attributes, $key, $this->serializeDate(
	$this->asDateTime(Arr::get($attributes, $key))
	));
	}
	}

[shaedrich]

@GromNaN Does #3105 support the dot syntax?

[GromNaN]

In fact, the query builder will convert any DateTimeInterface into UTCDatetime, and inversely for results. Regardless of the path, no need to specify any date casting. That the benefit of having a native date type in MongoDB vs SQL database that store strings for dates.

[shaedrich]

Awesome 👍🏻 Thanks for the clarification

[GromNaN]

Fixed by #3105