Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-5157 Convert aws tests to use python scripts #624

Merged
merged 20 commits into from
Mar 6, 2025

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 5, 2025

This is yet another attempt, this time with three drivers, including their AWS Lambda tests:

Node Driver: https://spruce.mongodb.com/task/mongo_node_driver_next_rhel8_test_lambda_test_lambda_aws_auth_example_patch_210720094d15bf72a07ba09e9957a8d9b8d81d80_67c8a6e39ed585000741dcc1_25_03_05_19_33_00/logs?execution=3&sortBy=STATUS&sortDir=ASC

C Driver: https://spruce.mongodb.com/version/67c8b310155642000786045c/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

PyMongo (using mongodb/mongo-python-driver#2180): https://spruce.mongodb.com/version/67c8b4c060fd8b00076eeef4/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Also adds a regression test for setting up AWS auth. The second bug was that env-creds and session-creds cannot be aliases to other commands. They have the same setup, but do not include user info in the MONGODB_URI, but as AWS environment variables.

@blink1073 blink1073 requested a review from NoahStapp March 5, 2025 21:21
@blink1073
Copy link
Member Author

cc @baileympearson @eramongodb

Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback; otherwise, LGTM.

blink1073 and others added 7 commits March 5, 2025 17:09
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
@blink1073 blink1073 merged commit ba75f25 into mongodb-labs:master Mar 6, 2025
73 of 75 checks passed
@blink1073 blink1073 deleted the PYTHON-5157-redux-2 branch March 6, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants