Feat/tsemach/add command for promote app #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 13, 2024 15:15
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
gregra81
reviewed
Dec 25, 2024
gregra81
reviewed
Dec 25, 2024
src/services/app-promote-service.ts
Outdated
| ): void => { | ||
| switch (status) { | ||
| case APP_VERSION_STATUS.DRAFT: { | ||
| task.title = 'Failed to promote the app, back to draft status'; |
There was a problem hiding this comment.
Suggested change
| task.title = 'Failed to promote the app, back to draft status'; | |
| task.title = 'Failed to promote the app, rolling back to a draft version'; |
gregra81
reviewed
Dec 25, 2024
src/services/app-promote-service.ts
Outdated
Comment on lines
94
to
96
| const { urlToPull, retryAfter } = ctx; | ||
| await sleep(retryAfter! * 1000); | ||
| await pollPromotionStatus(urlToPull!, task); |
There was a problem hiding this comment.
this can create issue, right? How do you know that retryAfter and urlToPull are not undefined?
gregra81
reviewed
Dec 25, 2024
added 2 commits
December 25, 2024 15:21
gregra81
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
app:promotecommand to the CLI.Features: