Fix #206 (Implement SRV lookup) #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Echolon
added
the
🚫 Bug / Stability
anurodhp
suggested changes
Apr 1, 2020
|
It may be beneficial to put your changes in different branches. There is a lot that i can merge here but the possible private api use means the app cant but put in the app store. |
|
no need to break out the changes, I'll just fix the api usage :) |
* Save message drafts * Using completion handler
This is a bugfix for usage of multiple SRV records and additionally adds xmpps SRV record and ALPN support
This reverts commit 2ffc1a5.
@marmistrz I create the file in here, so you can start committing and helping out. I will also link that within the read me. Thank you for you pre-work! @anurodhp I will merge this directly as a link in the ReadMe. If you disagree on anything just contact me!
Added link to XEP list
This reverts commit c30f81f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #206 and additionally fixes some bugs in the old SRV implementation (no retry with records having lower priority and not using the port value of the SRV record).