Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Avatar picture aspect-ratio and Notification bar nickname alignment #503

Closed
Echolon opened this issue Oct 18, 2020 · 1 comment · Fixed by #506
Closed

UI: Avatar picture aspect-ratio and Notification bar nickname alignment #503

Echolon opened this issue Oct 18, 2020 · 1 comment · Fixed by #506
Labels
🎨 UI Related to visual appreance of the app (User Interface) Minor Due to limited ressources, this issue will be treated with a minor priority. 🚫 Bug / Stability Releated directly to bugs or instability issues
Milestone
Monal 4.9

Comments

@Echolon
Copy link
Contributor

Echolon commented Oct 18, 2020 •
edited
Loading

Avatar picture aspect-ratio not respected

As you can seen there no dialogue to crop a picture nor the aspect-ratio respected and centered:

Notification bar nickname alignment

After editing the nickname of a user the top contact info not aligned correctly anymore. Likely it may uses a legacy information.

FYI @poormusic2001

Alpha: 4.9 18 Oct 2020 11:30
iOS 12

[x] I have cross-check this overview https://github.com/anurodhp/Monal/issues/322 as well es filtered for related labels https://github.com/anurodhp/Monal/labels
@Echolon Echolon added 🚫 Bug / Stability Releated directly to bugs or instability issues 🎨 UI Related to visual appreance of the app (User Interface) Minor Due to limited ressources, this issue will be treated with a minor priority. labels Oct 18, 2020
@Echolon Echolon added this to the Monal 4.9 milestone Oct 18, 2020
@Echolon
Copy link
Contributor Author

Echolon commented Oct 19, 2020

ref. #148

poormusic2001 added a commit to poormusic2001/Monal that referenced this issue Oct 20, 2020
@poormusic2001
UI: Avatar picture aspect-ratio and Notification bar nickname alignment
5f29d4e 
monal-im#503

1. Let notification bar nickname alignment to left.
2. Remove the unused variable, navBarContactDetailsButton.
3. Add tap action to go to contact detail.
@Echolon Echolon linked a pull request Oct 30, 2020 that will close this issue
Pr09 - Complete parser rewrite, XEP-0172, XEP-0084, OMEMO fixes #506
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 UI Related to visual appreance of the app (User Interface) Minor Due to limited ressources, this issue will be treated with a minor priority. 🚫 Bug / Stability Releated directly to bugs or instability issues
Projects
None yet
Milestone
Monal 4.9
Development

Successfully merging a pull request may close this issue.

Pr09 - Complete parser rewrite, XEP-0172, XEP-0084, OMEMO fixes
1 participant
@Echolon