(*)Add a halo update to fix VERTEX_SHEAR solutions #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added halo update for fluxes%p_surf_full when VERTEX_SHEAR=true. This field is not used directly with the vertex shear code, but its halo regions are used in the frazil code when the diabatic solver is using slightly wider halos to work with the VERTEX_SHEAR option for shear mixing. Without this change, some cases using VERTEX_SHEAR=True were not reproducing across PE layout, whereas now they do. There is no flag to recover the old answers because the old answers were ill-defined. All answers in the MOM6-examples test suite are bitwise identical but there will be answer changes in some ice-ocean or coupled cases with VERTEX_SHEAR=True; these cases should now reproduce across PE layouts.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1221 +/- ##
============================================
+ Coverage 46.08% 46.10% +0.02%
============================================
Files 214 224 +10
Lines 69399 70933 +1534
============================================
+ Hits 31984 32706 +722
- Misses 37415 38227 +812
Continue to review full report at Codecov.
|
adcroft
approved these changes
Oct 15, 2020
|
https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11388 🟡 ✔️ Note: parameters out of date due to pr/1217; This PR does not affect parameters so the parameters will be updated after this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added halo update for fluxes%p_surf_full when VERTEX_SHEAR=true. This field
is not used directly with the vertex shear code, but its halo regions are used
in the frazil code when the diabatic solver is using slightly wider halos to
work with the VERTEX_SHEAR option for shear mixing. Without this change, some
cases using VERTEX_SHEAR=True were not reproducing across PE layout, whereas now
they do. There is no flag to recover the old answers because the old answers
were ill-defined. All answers in the MOM6-examples test suite are bitwise
identical but there will be answer changes in some ice-ocean or coupled cases
with VERTEX_SHEAR=True; these cases should now reproduce across PE layouts.
This PR should help address MOM6 Issue #850.