Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use reactor artifacts before dependency or plugin artifacts #73

Merged
merged 1 commit into from
May 31, 2021
Merged

use reactor artifacts before dependency or plugin artifacts #73

merged 1 commit into from
May 31, 2021

Conversation

zuckel
Copy link
Contributor

@zuckel zuckel commented Mar 10, 2021

Currently if an artifact is both a project artifact (a sibling module) and also a dependency artifact, the latter one will win and make it to the classpath. An artifact from the repository will then be used instead of the current one from the active build.
This will break the build if there were any changes to one module that need to be visible to another module.

The solution is to reorder dependencies when building the class-path such that reactor artifacts are always considered first.

The scenario can happen e.g. in presence of a BOM such as created by cyclonedx-maven-plugin.

@bmarwell
Copy link
Contributor

Hi @zuckel!
Thanks a lot for your PR! I think we can include it in the next release.

I think we should create an issue for this and tag the commit message accordingly (e.g. [#xx] use reactor artifacts before dependency or plugin artifacts).
Thanks for the test case as well!

@zuckel
Copy link
Contributor Author

zuckel commented May 31, 2021

Ok, I'll open in issue and change the commit message.

@bmarwell bmarwell added this to the aspectj-maven-plugin 1.12.0 milestone May 31, 2021
@bmarwell bmarwell merged commit fd6a399 into mojohaus:master May 31, 2021
@zuckel zuckel deleted the fix_dependency_order branch May 31, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants