feat(stage-tamagotchi): system tray #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LemonNekoGH
requested review from
sumimakito,
nekomeowww,
luoling8192 and
kwaa
✅ Deploy Preview for drizzle-orm-duckdb-wasm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nekomeowww
reviewed
Feb 23, 2025
| }) | ||
|
|
||
| onMounted(() => { | ||
| // Is this a good idea? |
nekomeowww
approved these changes
Feb 23, 2025
nekomeowww
reviewed
Feb 23, 2025
There was a problem hiding this comment.
Need to export this file for @proj-airi/stage-web to include in types option in tsconfig.json.
nekomeowww
reviewed
Feb 23, 2025
packages/stage-ui/src/electron.d.ts
Outdated
Comment on lines
5
to
6
| electron: ElectronAPI | ||
| api: unknown |
There was a problem hiding this comment.
Suggested change
| electron: ElectronAPI | |
| api: unknown | |
| electron?: ElectronAPI | |
| api?: unknown |
Optional since it may not exist.
nekomeowww
reviewed
Feb 23, 2025
|
|
||
| onMounted(() => { | ||
| // Is this a good idea? | ||
| if (window.electron) { |
There was a problem hiding this comment.
Suggested change
| if (window.electron) { | |
| if (window.electron != null) { |
nekomeowww
reviewed
Feb 23, 2025
| @@ -178,6 +179,26 @@ onStreamEnd(async () => { | |||
|
|
|||
| onUnmounted(() => { | |||
| lipSyncStarted.value = false | |||
| if (window.electron) { | |||
There was a problem hiding this comment.
Suggested change
| if (window.electron) { | |
| if (window.electron != null) { |
nekomeowww
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.