feat(stage-ui): animate idle eye and focus movements on Live2D models #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for drizzle-orm-duckdb-wasm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sumimakito
force-pushed
the
feat/live2d-idle-eye-focus
branch
from
8666d63 to
63ef32c
Compare
nekomeowww
reviewed
Feb 11, 2025
Comment on lines
+109
to
+117
| const hookedUpdate = motionManager.update | ||
| motionManager.update = function (model, now) { | ||
| hookedUpdate?.call(this, model, now) | ||
| // Only update eye focus when the model is idle | ||
| if (motionManager.state.currentGroup === motionManager.groups.idle) { | ||
| idleEyeFocus.update(internalModel, now) | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
Don't worry, this should not be a big problem.
nekomeowww
reviewed
Feb 11, 2025
nekomeowww
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Animate idle eye saccades and focus (head) movements on Live2D models
For Live2D models: Eyeball movements will be turned off in all motions of the idle motion group to avoid conflicts