Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include symtab2gb conversion in --only-codegen #1585

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

#957 will need more fixes and discussions to be enabled. In the meantime, this PR includes the symtab2gb conversion step in --only-codegen runs, so that Kani fails if the conversion from Kani-generated symbol tables to GotoC program is invalid.

Resolved issues:

Resolves #1584

Call-outs:

Testing:

  • How is this change tested? Existing regression. Run locally the top 100 crates experiment, but it doesn't affect results.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner August 24, 2022 21:13
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome that it hasn't affected the top 100 crates results! Thanks

@adpaco-aws
Copy link
Contributor Author

It's awesome that it hasn't affected the top 100 crates results! Thanks

Unfortunately, these results shouldn't be trusted: #1563

@celinval
Copy link
Contributor

It's awesome that it hasn't affected the top 100 crates results! Thanks

Unfortunately, these results shouldn't be trusted: #1563

That's odd. I'm curious to know why that's the case.

@celinval celinval merged commit 22316d1 into model-checking:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend --only-codegen to use symtab2gb in addition
2 participants