Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify release bundle tests #2703

Closed
celinval opened this issue Aug 23, 2023 · 1 comment · Fixed by #2841
Closed

Unify release bundle tests #2703

celinval opened this issue Aug 23, 2023 · 1 comment · Fixed by #2841
Assignees
@celinval
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.

Comments

@celinval
Copy link
Contributor

Proposed change: We should run the same release bundle workflow for PR and release. The only difference is that during release, at the end of the workflow, we upload the artifacts.

Motivation: Having different workflows is harder to maintain and more error prone. I'm not aware of any reason why we should keep them different.

We should also consider restructuring the workflow into separate jobs. One to build the bundle, one that download and test the bundle and a third to publish.
@celinval celinval added the [C] Internal Tracks some internal work. I.e.: Users should not be affected. label Aug 23, 2023
@celinval
Copy link
Contributor Author

https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts#passing-data-between-jobs-in-a-workflow

@celinval celinval mentioned this issue Aug 23, 2023
Merged
4 tasks
@celinval celinval self-assigned this Aug 23, 2023
@celinval celinval mentioned this issue Oct 26, 2023
Merged
celinval added a commit that referenced this issue Oct 27, 2023
@celinval @zhassan-aws
Unify Kani bundle CI jobs (#2841)
81ec454 
We have two different ways today of building release bundles, one in
`kani.yml` and another one in `release.yml`, and only the `kani.yml`
actually run tests. This is error prone, since the release workflow only
runs during a release without validation tests, and the build can
diverge from what's being tested in CI.

Instead, we will always run the same workflow, except for the steps that
create the release.

Resolves #2703

Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@celinval celinval

Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.
Projects
No open projects
Kani 2023-09-12
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify Kani bundle CI jobs celinval/kani-dev
1 participant
@celinval