[new-allocator] Update new allocator to allocate node attachments as needed #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward ports the changes in moby#2725 to the new allocator. Signed-off-by: Drew Erny <drew.erny@docker.com>
wk8
reviewed
Nov 3, 2018
| service := store.GetService(tx, t.ServiceID) | ||
| if service != nil { | ||
| services = append(services, service) | ||
| // only new tasks need to be allocated. However, if a task |
There was a problem hiding this comment.
Not gonna lie, this 450 line-function is a bit hard to follow... Might be worthwhile to break it up a little bit?
There was a problem hiding this comment.
(comment on the whole processPendingAllocations func, not just this line)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Forward ports the changes in #2725 to the new allocator.
- How I did it
Rewrote portions of the codebase concerned with node allocation.
- How to test it
Includes automated tests