builder-next: call stopprogress on download error #39211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
approved these changes
May 14, 2019
thaJeztah
added
area/builder
status/2-code-review
process/cherry-pick
and removed
status/0-triage
labels
thaJeztah
added
status/4-merge
process/cherry-picked
and removed
status/2-code-review
process/cherry-pick
labels
AkihiroSuda
approved these changes
May 14, 2019
yongtang
added
rebuild/windowsRS5-process
and removed
rebuild/windowsRS5-process
labels
Codecov Report
@@ Coverage Diff @@
## master #39211 +/- ##
=========================================
Coverage ? 37.02%
=========================================
Files ? 612
Lines ? 45488
Branches ? 0
=========================================
Hits ? 16843
Misses ? 26351
Partials ? 2294 |
|
CI green. Ready for merge 👍 |
|
Thx @olljanat |
|
Wait; this is odd; I clicked the merge button, but GitHub shows the PR as still being open, and as if I closed the PR?
Looks like it's really merged into master though
|
|
I contacted GitHub support, just in case 👍 |
|
@thaJeztah no response? |
|
Nope, don't think so 😔 |
|
can we retry to close this? |
|
interesting; tried that earlier and didn't work; now looks like it did (I did reach out to hem again today, perhaps they fixed something?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress needs to be stopped on download error as well to avoid defer from hanging.
@tiborvass @AkihiroSuda
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com