-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for RingLogger's ring buffer #37084
Merged
anusha-ragunathan
merged 1 commit into
moby:master
from
nwneisen:update-ring-buffer-documents
May 17, 2018
Merged
Update documentation for RingLogger's ring buffer #37084
anusha-ragunathan
merged 1 commit into
moby:master
from
nwneisen:update-ring-buffer-documents
May 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
boaz0
approved these changes
May 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
thaJeztah
approved these changes
May 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
|
Janky failing on #36501
|
PowerPC also failing on a flaky test #32673
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36556
- What I did
Update RingLogger documentation to correctly describe the ring buffer's behavior.
- How I did it
Examined code to make sure documentation changes were accurate before modifying the comments.
- How to verify it
Read documentation before an after.
- Description for the changelog
Update documentation for RingLogger's ring buffer.
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Nick Neisen nwneisen@gmail.com