Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: allow subdirs for remote contexts #961

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

tonistiigi
Copy link
Member

Allow specifying a subdir when building from a remote context. For example, if building from tarball that contains multiple projects.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Copy link
Collaborator

@ijc ijc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work for ~any remote (including git), right?

@tonistiigi
Copy link
Member Author

@ijc . Git, yes. But not for local files.

@ijc
Copy link
Collaborator

ijc commented Apr 26, 2019

Ack, for local files (llb.Local) that's a client side filepath.Join on the input or the same thing manually in the frontend (e.g. dropping in an llb.Dir somewhere) I suppose.

@tonistiigi tonistiigi merged commit 37ae84b into moby:master Apr 26, 2019
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Apr 27, 2019
full diff: moby/buildkit@8818c67...v0.5.0

- moby/buildkit#909 exporter: support unpack opt for image exporter
- moby/buildkit#961 dockerfile: allow subdirs for remote contexts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request May 11, 2019
full diff: moby/buildkit@8818c67...v0.5.0

- moby/buildkit#909 exporter: support unpack opt for image exporter
- moby/buildkit#961 dockerfile: allow subdirs for remote contexts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 3e4723cf3395dcdaa4c98acba549ac0170899504
Component: engine
thaJeztah added a commit to thaJeztah/docker that referenced this pull request May 14, 2019
full diff: moby/buildkit@8818c67...v0.5.0

- moby/buildkit#909 exporter: support unpack opt for image exporter
- moby/buildkit#961 dockerfile: allow subdirs for remote contexts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 3e4723c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request May 14, 2019
full diff: moby/buildkit@8818c67...v0.5.0

- moby/buildkit#909 exporter: support unpack opt for image exporter
- moby/buildkit#961 dockerfile: allow subdirs for remote contexts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 3e4723cf3395dcdaa4c98acba549ac0170899504)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: ea090084234de4776289445b6e648622d874c49a
Component: engine
kiku-jw pushed a commit to kiku-jw/moby that referenced this pull request May 16, 2019
full diff: moby/buildkit@8818c67...v0.5.0

- moby/buildkit#909 exporter: support unpack opt for image exporter
- moby/buildkit#961 dockerfile: allow subdirs for remote contexts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants