Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update buildkit to latest rc #2669

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

tonistiigi
Copy link
Member

Let's switch to the latest test release to make sure CI doesn't catch anything.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@crazy-max
Copy link
Member

crazy-max commented Feb 23, 2022

@tonistiigi This one is odd: https://github.com/moby/buildkit/runs/5299617535?check_suite_focus=true#step:6:1003

#62 [buildkit-version 1/1] RUN --mount=target=.   PKG=github.com/moby/buildkit VERSION=$(git describe --match 'v[0-9]*' --dirty='.m' --always --tags) REVISION=$(git rev-parse HEAD)$(if ! git diff --no-ext-diff --quiet --exit-code; then echo .m; fi);   echo "-X ${PKG}/version.Version=${VERSION} -X ${PKG}/version.Revision=${REVISION} -X ${PKG}/version.Package=${PKG}" | tee /tmp/.ldflags;   echo -n "${VERSION}" | tee /tmp/.version;
#62 0.358 .buildkit_qemu_emulator: /bin/sh: Invalid ELF image for this architecture

Could be linked to latest QEMU? (#2634)

@@ -27,7 +27,7 @@ FROM --platform=$BUILDPLATFORM golang:1.17-alpine AS golatest
# gobuild is base stage for compiling go/cgo
FROM golatest AS gobuild-base
RUN apk add --no-cache file bash clang lld pkgconfig git make
COPY --from=xx / /
COPY --link --from=xx / /
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the problem w/ cross, is this line wrong?

pop, md := MarshalConstraints(constraints, &m.constraints)
pop.Platform = nil // merge op is not platform specific

I may have misunderstood how platform constraints work.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Copy link
Member Author

Updated frontend to master to get the fix from #2672

@tonistiigi tonistiigi merged commit a99e318 into moby:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants