Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory overhead of tracking #3833

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Reduce memory overhead of tracking #3833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7897edd
20% legroom only
realyze Feb 18, 2024
a373160
Code golf
realyze Feb 19, 2024
f70e108
Merge branch 'main' into tomas/tracking-memory-overhead-reduction
realyze Mar 4, 2024
1d4893a
Better initial deps detection
realyze Mar 4, 2024
225cd2c
comment golf
realyze Mar 4, 2024
bb346b1
remove ceil
realyze Mar 4, 2024
c399fd2
Add link to PR
realyze Mar 6, 2024
fcbcf17
Changeset
realyze Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-numbers-prove.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mobx": patch
---

Reduce memory overhead of tracking dependencies
9 changes: 6 additions & 3 deletions packages/mobx/src/core/derivation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,13 @@ export function checkIfStateReadsAreAllowed(observable: IObservable) {
*/
export function trackDerivedFunction<T>(derivation: IDerivation, f: () => T, context: any) {
const prevAllowStateReads = allowStateReadsStart(true)
// pre allocate array allocation + room for variation in deps
// array will be trimmed by bindDependencies
changeDependenciesStateTo0(derivation)
derivation.newObserving_ = new Array(derivation.observing_.length + 100)
// Preallocate array; will be trimmed by bindDependencies.
derivation.newObserving_ = new Array(
// Reserve constant space for initial dependencies, dynamic space otherwise.
// See https://github.com/mobxjs/mobx/pull/3833
derivation.runId_ === 0 ? 100 : derivation.observing_.length
)
derivation.unboundDepsCount_ = 0
derivation.runId_ = ++globalState.runId
const prevTracking = globalState.trackingDerivation
Expand Down