Fix project urls in pyproject.toml #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the project urls "homepage" and "repository" were pointing to mne-bids-pipeline and not mne-qt-browser. I don't think there is a homepage, right? An option might be to just remove the homepage url if there isn't any. I made it point to the GitHub repo for the moment. Additionally changed "changelog" to https url. Sorry for not creating an issue first, I was a bit lazy and I was hoping this would be okay since there is no change to the actual code.
mscheltienne
approved these changes
Apr 18, 2024
Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
|
Great, thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for not creating an issue first, I was a bit lazy and I was hoping this would be okay since there is no change to the actual code.
I noticed that the project urls "homepage" and "repository" were pointing to mne-bids-pipeline and not mne-qt-browser (these links appear for example on the PyPi release page).
I fixed the repository url, but don't think there is a homepage, right? An option might be to just remove the homepage url if there isn't any. I made it also point to the GitHub repo for the moment.
Additionally I changed "changelog" to an https not http url.