Skip to content

Use hatchling as build backend #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

hoechenberger
Copy link
Member

To fix editable installs. We already switched over MNE-Python, MNE-BIDS, and MNE-BIDS-Pipeline.

To fix editable installs.
We already switched over MNE-Python, MNE-BIDS, and
MNE-BIDS-Pipeline.
@hoechenberger hoechenberger marked this pull request as ready for review December 9, 2023 10:29
@hoechenberger hoechenberger requested review from larsoner and marsipu and removed request for larsoner December 9, 2023 10:42
marsipu
marsipu previously approved these changes Dec 9, 2023
Co-authored-by: Martin Schulz <dev@mgschulz.de>
@marsipu marsipu dismissed their stale review December 9, 2023 11:27

No experience with hatchling

@marsipu
Copy link
Member

marsipu commented Dec 9, 2023

I don't have experience with hatchling yet so I probably better leave approval to others (or since you already did the transition with the other packages you can probably just merge it)
Thank you @hoechenberger

@hoechenberger
Copy link
Member Author

Yes let's wait for @larsoner's feedback / thoughts

@larsoner larsoner merged commit 5dc1625 into mne-tools:main Dec 11, 2023
@larsoner
Copy link
Member

Thanks @hoechenberger @marsipu

I checked and hopefully won't run into the .gitignore problem omitting files we hit with MNE-Python 🤞

@hoechenberger hoechenberger deleted the hatchling branch December 11, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants