remove add/remove objects for view-range #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larsoner Are the remaining failing CIs related to some xvfb or similar problems on Ubuntu for older mne-versions? |
|
Nice, much less code than before!!!! |
hoechenberger
approved these changes
Aug 14, 2022
|
FYI I added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #82
What does this implement/fix?
This fixes an issue where in an interactive python console some Qt-Objects had been deleted if they hadn't been added to the Scene.
Before on every change of X-Range, Qt-Objects for Annotations and Events had been added and removed according to if they appear in this X-Range or not. In early testing this had been proven to be more performant with large sets of Annotations/Events.
This PR removes that and always adds all Qt-Objects for Annotations and Events to the Scene where Qt handles everything then.
With reasonable amounts of Annotations/Events (probably most common usecase) this new solutionis probably as good if not even better.
IMHO running the browser in an interactive python console without issue outweighs a potential benefit the former method had in some rarer cases.