Skip to content

BUG: Fix crosshair #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2022
Merged

BUG: Fix crosshair #124

merged 1 commit into from
Jun 18, 2022

Conversation

marsipu
Copy link
Member

@marsipu marsipu commented Jun 18, 2022

What does this implement/fix?

This fixes a small bug when using the crosshair (activated by pressing x).

@marsipu marsipu added the bug Something isn't working label Jun 18, 2022
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a what's new entry to document the bug fix?

@larsoner
Copy link
Member

I think so far there is no latest.inc for this repo and changes just end up in the Releases page, auto-generated. Though I suppose you could add an entry to MNE-Python!

@larsoner larsoner merged commit d9c2370 into mne-tools:main Jun 18, 2022
@hoechenberger
Copy link
Member

changes just end up in the Releases page, auto-generated

I would therefore encourage everyone to be a bit more verbose when it comes to PR titles, as this is what will show up in the auto-generated changelog. Neither from the title of this PR nor from any comments here can I deduce what was even the problem 😅

@marsipu marsipu deleted the fix_crosshair branch June 18, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants