Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server example #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update server example #30

wants to merge 1 commit into from

Conversation

djui
Copy link

@djui djui commented Aug 19, 2016

Try to keep the server example in sync with the latest implementation.

7ca58a5 started this effort but only for the client example.

Try to keep the server example in sync with the latest implementation.

mlalic@7ca58a5 started this effort but only for the client example.
@djui
Copy link
Author

djui commented Aug 19, 2016

In general I am a bit worried about the current state of versioning:

  • Neither v0.4.4 of the crate work with the example.
  • Nor does master work with the example.

The API has changed beyond and requires a new version. The example code works with master.

I would suggest to make the current state of the project obvious in the head of the README.md and additionally clearly state with examples work with the crate version (v0.4.4) and which would work with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant