Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reloadOnMissingCSS option, see livereload-js. #93

Merged
merged 3 commits into from
Jan 22, 2018

Conversation

STRML
Copy link
Contributor

@STRML STRML commented Aug 13, 2015

Corresponding livereload-js PR: livereload/livereload-js#41

@shama
Copy link
Collaborator

shama commented Sep 27, 2015

Waiting on a response from livereload/livereload-js#41

@mklabs
Copy link
Owner

mklabs commented May 30, 2016

Hi guys, we may put this on hold since livereload/livereload-js#41 is on hold as well.

I'm thinking about forking livereload-js to enable us more freedom in the client side. And probably port it to ES6 and babel instead of coffee.

@elwayman02
Copy link
Collaborator

👍 on forking livereload-js, seems abandoned. Double 👍 on moving to ES6/babel, yay!

@mklabs
Copy link
Owner

mklabs commented Aug 13, 2016

Hi @STRML I'm sorry but I'll close your PR for the moment. As soon as we can have updates from livereloadjs or decide to make and build our own version of livereloadjs, we may reconsider this option.

I hope you understand.

@mklabs mklabs closed this Aug 13, 2016
@STRML
Copy link
Contributor Author

STRML commented Aug 13, 2016

Thanks - but if you consider this on hold, why not keep it open and label
rather than close, where it could be lost?

On Aug 13, 2016 5:15 AM, "Mickael Daniel" notifications@github.com wrote:

Hi @STRML https://github.com/STRML I'm sorry but I'll close your PR for
the moment. As soon as we can have updates from livereloadjs or decide to
make and build our own version of livereloadjs, we may reconsider this
option.

I hope you understand.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#93 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABJFP4AuWFRwwb_qZLrig-VYyXuWCgjlks5qfZk0gaJpZM4FrNCN
.

@mklabs
Copy link
Owner

mklabs commented Aug 13, 2016

Fine, let's keep it opened. This was just in order to clean up old issues / PR

@mklabs mklabs reopened this Aug 13, 2016
@elwayman02
Copy link
Collaborator

@STRML might want to rebase while we're waiting, so it's good to go when the upstream gets resolved.

@elwayman02
Copy link
Collaborator

@STRML would you mind resolving conflict on this branch with a rebase? We finally have a maintainer active in livereload-js and I'm hopeful we can get your upstream PR merged soon so we can finally land this feature!

@STRML
Copy link
Contributor Author

STRML commented Jan 12, 2018

@elwayman02 Rebased it - 👍

@elwayman02
Copy link
Collaborator

Awesome, thanks! I'll do my best to keep an eye on the upstream PR and get that into tiny-lr asap.

@elwayman02 elwayman02 merged commit ecbd07f into mklabs:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants